Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CRAN note about too many dependencies #1612

Merged
merged 2 commits into from Apr 6, 2021
Merged

Fix CRAN note about too many dependencies #1612

merged 2 commits into from Apr 6, 2021

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Apr 6, 2021

Fix #1559

@maelle maelle changed the title rm deps Fix CRAN note about too many dependencies Apr 6, 2021
@maelle
Copy link
Collaborator Author

maelle commented Apr 6, 2021

Note that if the local search index file ends up being a JSON file, jsonlite will become a hard dependency.

maelle
maelle commented Apr 6, 2021
View reviewed changes
DESCRIPTION
@@ -34,18 +34,15 @@ Imports:
digest,
downlit,
fs (>= 1.3.0),
htmltools,
Copy link
Collaborator Author

@maelle maelle Apr 6, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed 4 Imports which puts the number of Imports at 19, removing 3 would have been enough as the limit is 20 at the moment.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

htmltools is a hard dependency of bslib.

maelle
maelle commented Apr 6, 2021
View reviewed changes
DESCRIPTION
httr (>= 1.4.2),
magrittr,
memoise,
openssl,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hard dependency of httr and only used

  • for building favicons;
  • in a superseded function for deployment.

@maelle maelle marked this pull request as ready for review April 6, 2021 09:14
@maelle maelle merged commit 5fe9f58 into master Apr 6, 2021
@maelle maelle deleted the bye-note branch April 6, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CRAN note about too many dependencies
2 participants
@maelle @hadley