Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add local search #1629

Merged
merged 59 commits into from
Apr 30, 2021
Merged

Add local search #1629

merged 59 commits into from
Apr 30, 2021

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Apr 19, 2021 •
edited
Loading

Fix #1407
Fix #1632
Fix #1531
Fix #1341
Fix #973

servr::httw("docs") for local testing.

@maelle

This comment has been minimized.

Sign in to view
@maelle

This comment has been minimized.

Sign in to view
@maelle

This comment has been minimized.

Sign in to view
@maelle

This comment has been minimized.

Sign in to view
maelle
maelle commented Apr 20, 2021
View reviewed changes
.Rbuildignore Show resolved Hide resolved
maelle
maelle commented Apr 20, 2021
View reviewed changes
DESCRIPTION Show resolved Hide resolved
maelle
maelle commented Apr 27, 2021
View reviewed changes
R/build-news.R Show resolved Hide resolved
@maelle maelle requested a review from hadley April 27, 2021 12:31
hadley
hadley reviewed Apr 27, 2021
View reviewed changes
.github/workflows/pkgdown.yaml Outdated Show resolved Hide resolved
.github/workflows/pkgdown.yaml Show resolved Hide resolved
DESCRIPTION Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
R/build-news.R Outdated Show resolved Hide resolved
R/build-news.R Show resolved Hide resolved
R/build-news.R Show resolved Hide resolved
R/build-search-docs.R Outdated Show resolved Hide resolved
inst/templates/BS4/head.html Outdated Show resolved Hide resolved
vignettes/search.Rmd Outdated Show resolved Hide resolved
@maelle maelle mentioned this pull request Apr 27, 2021
Merged
maelle and others added 5 commits April 27, 2021 15:14
@maelle @hadley
Update NEWS.md
d887919 
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
@maelle @hadley
Update R/build-news.R
2be54d3 
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
@maelle
comments from review
ef51a6e
@maelle
not bold v number only
1cc4bca
@maelle
fix indent
eea5100
@maelle maelle requested a review from hadley April 27, 2021 14:46
maelle
maelle commented Apr 30, 2021
View reviewed changes
NEWS.md Show resolved Hide resolved
hadley
hadley approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Once you update the test and fix the build failures, I think it's good to merge. Then we can do a little more smaller iteration.

@maelle maelle merged commit 23a0415 into master Apr 30, 2021
@maelle maelle deleted the local-search branch April 30, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@maelle @hadley