Allow topics from other packages in reference index #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notes: simplify, no need to rebuild topics. |
maelle
commented
May 7, 2021
maelle
commented
May 7, 2021
maelle
commented
May 7, 2021
maelle
commented
May 14, 2021
hadley
reviewed
May 21, 2021
hadley
reviewed
Jun 2, 2021
R/topics.R
Outdated
Comment on lines
209
to
214
| db <- tools::Rd_db(names[1]) | ||
| Rd <- db[[rd_name]] | ||
| # adapted from printr | ||
| # https://github.com/yihui/printr/blob/0267c36f49e92bd99e5434f695f80b417d14e090/R/help.R#L69 | ||
| sections <- sub('^\\\\', '', unlist(lapply(Rd, attr, 'Rd_tag'))) | ||
| title <- as.character(Rd[sections == "title"][[1]]) |
There was a problem hiding this comment.
Pull this out into a separate named function just to clarify the purpose.
@yihui can you please confirm that it's ok for us to use your GPL licensed code in our MIT licensed package?
There was a problem hiding this comment.
Thank you!
However I am now extremely embarrassed to have at last remembered where else code for parsing Rd files lives... in pkgdown itself! 🤦♀️ 🙈
There was a problem hiding this comment.
Still using a bit of printr logic though, for finding the Rd.
maelle
commented
Jun 3, 2021
maelle
commented
Jun 3, 2021
hadley
reviewed
Jun 15, 2021
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
hadley
approved these changes
Aug 31, 2021
NEWS.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| # pkgdown (development version) | |||
|
|
|||
| * `build_reference()` now allows linking to topics from other packages (either function names e.g. `rlang::is_installed` or topic names e.g. `sass::font_face`). (#1664) | |||
|
|
|||
| * New template option `trailing_slash_redirect` that allows adding a script to redirect `your-package-url.com` to `your-package-url.com/`. (#1439, @cderv, @apreshill) | |||
maelle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1251
Fix #1351