Absolute URL in search index #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Sep 17, 2021
R/build-search-docs.R
Outdated
| @@ -113,6 +113,14 @@ build_search_index <- function(pkg) { | |||
|
|
|||
| purrr::compact(index) | |||
|
|
|||
| # Make URLs absolute if possible | |||
| url <- pkg$meta$url %||% "/" | |||
There was a problem hiding this comment.
Are you sure this shouldn't be ""? The url you use in the test doesn't have a trailing slash. Maybe worth testing the case of no default url?
There was a problem hiding this comment.
You were right! I added a test.
In the test I was surprised I had to make sure the file for the two cases was not the same. I think it's because for other snapshot tests, one does not have to worry about overwriting another snapshot. Good to know. 😅
GregorDeCillia
added a commit
to statistikat/STATcubeR
that referenced
this pull request
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1770
Not possible to use the "../" strategy here as the search index is the same for the whole website.
For context, this fixes a wrong assumption about what the root is (not necessarily the production website, e.g. see pkgdown websites hosted on GitHub pages).