Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build_reference_index items checks #1995

Merged
merged 7 commits into from
Jan 6, 2022
Merged

fix build_reference_index items checks #1995

merged 7 commits into from
Jan 6, 2022

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Jan 6, 2022

Fix #1941

Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a news bullet too please?

R/build-reference-index.R Outdated Show resolved Hide resolved
R/build-reference-index.R Outdated Show resolved Hide resolved
R/build-reference-index.R Outdated Show resolved Hide resolved
maelle and others added 5 commits January 6, 2022 20:00
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
@maelle maelle requested a review from hadley January 6, 2022 19:04
@maelle
Copy link
Collaborator Author

maelle commented Jan 6, 2022

Oops, didn't see the approval, I might merge it myself tomorrow.

@hadley hadley merged commit 3e465e1 into main Jan 6, 2022
@hadley
Copy link
Member

hadley commented Jan 6, 2022

Too late 😉

@hadley hadley deleted the missingitem branch January 6, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing error message
2 participants