Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show missing vignettes in abort message #2121

Merged
merged 4 commits into from Jun 16, 2022
Merged

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented Jun 10, 2022

This fixes an abort() message for vignettes to actually reveal the vignettes that are missing as shown in the snapshot test:

      Error in `data_articles_index()`:
-      ! Vignettes missing from index: 
+      ! Vignettes missing from index: articles/nested, width

@zkamvar zkamvar marked this pull request as ready for review June 11, 2022 01:22
@hadley
Copy link
Member

hadley commented Jun 13, 2022

Thanks for working on this! Can you please add a bullet to the top of NEWS.md? It should briefly describe the change and end with (@yourname, #issuenumber).

@hadley hadley merged commit d8e324b into r-lib:main Jun 16, 2022
@zkamvar zkamvar deleted the fix-vignette-abort branch June 20, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants