Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds "Getting help" to "Community" on homepage #2125

Merged
merged 4 commits into from
Jun 14, 2022
Merged

Adds "Getting help" to "Community" on homepage #2125

merged 4 commits into from
Jun 14, 2022

Conversation

IndrajeetPatil
Copy link
Contributor

@IndrajeetPatil IndrajeetPatil commented Jun 13, 2022

Closes #2124

Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a bullet to the top of NEWS.md? It should briefly describe the change and end with (@yourname, #issuenumber).

R/build-home-community.R Outdated Show resolved Hide resolved
Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
@IndrajeetPatil
Copy link
Contributor Author

Can you please add a bullet to the top of NEWS.md? It should briefly describe the change and end with (@yourname, #issuenumber).

I had already included this! Let me know if you want me to modify the exact description of the entry.

NEWS.md Outdated
@@ -1,5 +1,8 @@
# pkgdown (development version)

* If `SUPPORT.md` is present in `/.github` folder, it will be included on
homepage as "Getting help" (@patilindrajeets, #2124).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't your github user name @IndrajeetPatil?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL. Sorry, included the Twitter handle instead of GitHub! 😅

@hadley hadley merged commit 7632597 into r-lib:main Jun 14, 2022
@IndrajeetPatil IndrajeetPatil deleted the add_getting_help branch June 14, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include "Getting help" in the "Community" section on homepage
2 participants