Remove unwanted linebreaks

[salim-b]

Normalizes whitespace chars within content extracted from DESCRIPTION file fields.

Successor to #1543.

[hadley]

This seems like a very broad change with a high potential for risk — what happens if the paragraph contains an Rd tag where whitespace is important?

[salim-b]

It's quite a while ago I was concerned with this change, thus your question leaves me a bit unsure right now. In principle, the squishing is only done to elements that are neither a) block-level tags nor b) consist of only newlines:

pkgdown/R/rd-html.R

Lines 42 to 50 in 9fc86b1

	# There are three types of blocks:
	# 1. Combined text and inline tags
	# 2. Paragraph breaks (text containing only "\n")
	# 3. Block-level tags
	#
	# Need to wrap 1 in <p>
	needs_p <- (!(is_nl | is_block)) %>%
	split(groups) %>%
	purrr::map_lgl(any)

Are there inline Rd tags where whitespace semantically matters? If so, could you provide a quick example?

[hadley]

I think unfortunately the burden of proof is on you to proof that there aren't any places where this would cause a problem. IMO it doesn't seem worth the analysis (and convincing me) given that the benefit is small and not user facing (since HTML's whitespace rules already make this problem invisible).

[salim-b]

I see. I'm not familiar enough with the subtleties of the R documentation syntax and a quick scan of the official documentation didn't lead to an answer. So I've reverted to str_trim() in 1b793c2 (with a heavy heart, of course 😩).

[hadley]

Thanks for bearing with it!