Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Use realfavicongenerator API to build high-res PNG favicons #883
This is still WIP but I'm putting it here if you want to have a first look and tell me if I'm going in the wrong direction. I still need to:
Among others, I would like you to review:
This is great and much simpler than I had anticipated! I have given you a bunch of comments to help make the code more robust (these are tips I've learned through getting them all wrong myself!)
I'm also wondering if it would be better to pull this out into a separate
@hadley, thank you for your comments. I addressed some of them and I will probably have a look at the rest tomorrow.
I did the last changes in numerous small commits to make it easier to review. But once everything is ready to go, I can rebase & squash and force push.
Yeah, I forgot, I was thinking we could maybe add a check at the beginning of this function or in