Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUse realfavicongenerator API to build high-res PNG favicons #883
Conversation
Bisaloo
changed the title
Use realfavicongenerator API to build high-res PNG favicons
[WIP] Use realfavicongenerator API to build high-res PNG favicons
Nov 11, 2018
Bisaloo
force-pushed the
Bisaloo:png-favicons
branch
from
fc25ac5
to
29b352a
Nov 11, 2018
hadley
reviewed
Nov 11, 2018
This is great and much simpler than I had anticipated! I have given you a bunch of comments to help make the code more robust (these are tips I've learned through getting them all wrong myself!) I'm also wondering if it would be better to pull this out into a separate |
NEWS.md Outdated
R/build-logo.R Outdated
R/build-logo.R Outdated
R/build-logo.R Outdated
R/build-logo.R Outdated
hadley
reviewed
Nov 11, 2018
This comment has been minimized.
This comment has been minimized.
I think we should use a shared key that I register, providing an option for users to override if they want to provide their own. |
This comment has been minimized.
This comment has been minimized.
@hadley, thank you for your comments. I addressed some of them and I will probably have a look at the rest tomorrow. I did the last changes in numerous small commits to make it easier to review. But once everything is ready to go, I can rebase & squash and force push.
Yeah, I forgot, I was thinking we could maybe add a check at the beginning of this function or in |
This comment has been minimized.
This comment has been minimized.
Do we want a better default favicon while we're at this? Currently it's a (lo-res) blank black hex. |
This comment has been minimized.
This comment has been minimized.
@Bisaloo I think it would be better to be explicit about it and force the user to call a function. (Also you don't need to squash on your end, as I can squash when merging) @jayhesselberth I think we can ditch the default favicon now that we no longer need magick. |
hadley
reviewed
Nov 12, 2018
NEWS.md Outdated
R/build-logo.R Outdated
This comment has been minimized.
This comment has been minimized.
So I just tested and this works perfectly for |
Bisaloo
reviewed
Nov 12, 2018
R/build-logo.R Outdated
hadley
reviewed
Nov 12, 2018
Yes, should definitely prefer svg logos now. I think it's fine to include that here since it should be a fairly small change. |
This comment has been minimized.
This comment has been minimized.
I'd suggest that you also run the function on pkgdown itself and check in the results. |
Bisaloo
added some commits
Nov 7, 2018
Bisaloo
force-pushed the
Bisaloo:png-favicons
branch
from
ab1406b
to
05c51bd
Nov 13, 2018
This comment has been minimized.
This comment has been minimized.
Bisaloo
reviewed
Nov 13, 2018
This comment has been minimized.
This comment has been minimized.
The API also creates a bunch of files that we don't use ( |
Bisaloo
added some commits
Nov 13, 2018
hadley
reviewed
Nov 13, 2018
I think we should include them to the template too. We probably also need to make the template only include them if the favicons are actually present |
Bisaloo
added some commits
Nov 13, 2018
Bisaloo
reviewed
Nov 13, 2018
R/init.R Outdated
This comment has been minimized.
This comment has been minimized.
I'm not sure how to do that |
This comment has been minimized.
This comment has been minimized.
In that case, let me do a final review of this work, and then I can merge it. Then I can figure out how to let the template know. |
hadley
reviewed
Nov 13, 2018
Bisaloo
reviewed
Nov 13, 2018
inst/templates/head.html Outdated
Bisaloo
added some commits
Nov 13, 2018
This comment has been minimized.
This comment has been minimized.
Are you happy for me to merge this now? |
Bisaloo
changed the title
[WIP] Use realfavicongenerator API to build high-res PNG favicons
Use realfavicongenerator API to build high-res PNG favicons
Nov 13, 2018
This comment has been minimized.
This comment has been minimized.
Yeah, I just tested locally one last time and everything seems to work fine so I guess it's good to go. |
This comment has been minimized.
This comment has been minimized.
Awesome, thank you so much for all your hard work on this! |
hadley
merged commit e876818
into
r-lib:master
Nov 13, 2018
This comment has been minimized.
This comment has been minimized.
Thank you for all your comments! And don't forget to register your API key |
This comment has been minimized.
This comment has been minimized.
I signed up yesterday, but still haven't received the email |
Bisaloo commentedNov 11, 2018
•
edited
fix #845, fix #869
This is still WIP but I'm putting it here if you want to have a first look and tell me if I'm going in the wrong direction. I still need to:
svg
build_favicon()
Among others, I would like you to review:
pkgdown
users, hardcoded in the code? Asking users to register one themselves would introduce more complexity.