Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass params from deploy_site_github to build_site #922

Merged
merged 1 commit into from Dec 3, 2018
Merged

Conversation

@noamross
Copy link
Contributor

@noamross noamross commented Nov 29, 2018

This PR allows parameters to be passed from deploy_site_github() to build_site(), which is the documented behavior but is not implemented.

@hadley hadley added this to the pkgdown 1.2.1 milestone Dec 3, 2018
Copy link
Member

@hadley hadley left a comment

Oops!

Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).

@noamross
Copy link
Contributor Author

@noamross noamross commented Dec 3, 2018

Done, rebased and squashed.

@hadley hadley merged commit 62f07bc into r-lib:master Dec 3, 2018
2 of 4 checks passed
@hadley
Copy link
Member

@hadley hadley commented Dec 3, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants