Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable stdio (++) handle inheritance #132

Merged
merged 2 commits into from
Jul 22, 2018
Merged

Conversation

gaborcsardi
Copy link
Member

This can be called in an R child process, e.g. in callr.

It is based on the libuv function uv_disable_stdio_inheritance:
http://docs.libuv.org/en/v1.x/process.html#c.uv_disable_stdio_inheritance

Closes #131.

@gaborcsardi
Copy link
Member Author

This is pretty hard to test, but maybe I can put together sg.

@codecov-io
Copy link

codecov-io commented Jun 12, 2018

Codecov Report

Merging #132 into master will decrease coverage by 0.84%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   70.41%   69.57%   -0.85%     
==========================================
  Files          29       29              
  Lines        2762     2800      +38     
==========================================
+ Hits         1945     1948       +3     
- Misses        817      852      +35
Impacted Files Coverage Δ
src/init.c 100% <ø> (ø) ⬆️
src/win/stdio.c 71.87% <0%> (-5.72%) ⬇️
R/connections.R 72% <0%> (-1.47%) ⬇️
src/processx-connection.c 79.96% <0%> (-2.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e93ed4...30fd601. Read the comment docs.

@gaborcsardi gaborcsardi merged commit 67e4b59 into master Jul 22, 2018
@gaborcsardi gaborcsardi deleted the feature/disable-inherit branch July 23, 2018 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants