-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ps_cpu_count returning NA on Windows 10 #77
Comments
I am on the same exact versions, and get the correct answers: > ps::ps_cpu_count(TRUE)
[1] 8
> ps::ps_cpu_count(FALSE)
[1] 8 |
OK, this has to do with the ps binary package built on an older version of Windows. If you install the source package from CRAN, then in works. |
Wow, good find. I wonder what a good long-term solution is? CRAN isn't going to have multiple binaries for different versions of Windows, I don't think. Also, how many other packages might be similarly affected? |
The windows APIs are very stable, so I don't think this is a common thing. I am not even sure why it is happening, but I would need an old windows first to debug it. |
Winbuilder runs Windows Server 2008, and Azure has images available for Server 2008 R2. Is that ok? I can spin up a VM for you if necessary. |
R2 is not ok, because CRAN uses a plain 2008, I think. :( I have one on a VM. But I need to submit ps now to fix a build issue on Solaris, so I'll have to come back to this later. |
Maybe I can use a workaround on windows for now, I think I'll do that. |
We cannot choose between OSes using macros, because the binaries built on one system must work on another. Closes #77.
We cannot choose between OSes using macros, because the binaries built on one system must work on another. Closes #77.
We cannot choose between OSes using macros, because the binaries built on one system must work on another. Closes #77.
Both with logical=TRUE and FALSE. This is with Win 10 Pro 1909, build 18383.
The text was updated successfully, but these errors were encountered: