Fix renderGroup

r-lib · May 14, 2024 · c9052a6 · c9052a6
1 parent 827f25f
commit c9052a6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # ragg (development version)
 
+* Fix a bug in how groups are defined and recalled
+
 # ragg 1.3.1
 
 * Make sure the linejoin/linemitre setting is honored when drawing rectangles

diff --git a/src/AggDevice.h b/src/AggDevice.h
@@ -498,6 +498,7 @@ AggDevice<PIXFMT, R_COLOR, BLNDFMT>::AggDevice(const char* fp, int w, int h, dou
   recording_mask(NULL),
   current_mask(NULL),
   pattern_cache_next_id(0),
+  group_cache_next_id(0),
   recording_raster(NULL),
   recording_group(NULL)
 {
@@ -929,9 +930,6 @@ void AggDevice<PIXFMT, R_COLOR, BLNDFMT>::removePattern(SEXP ref) {
 
 template<class PIXFMT, class R_COLOR, typename BLNDFMT>
 SEXP AggDevice<PIXFMT, R_COLOR, BLNDFMT>::renderGroup(SEXP source, int op, SEXP destination) {
-  if (Rf_isNull(source)) {
-    return Rf_ScalarInteger(-1);
-  }
   int key = group_cache_next_id;
   group_cache_next_id++;