Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade=FALSE is not passed through to dependent installations #53

Closed
richfitz opened this issue Feb 17, 2017 · 1 comment
Closed

upgrade=FALSE is not passed through to dependent installations #53

richfitz opened this issue Feb 17, 2017 · 1 comment

Comments

@richfitz
Copy link

@richfitz richfitz commented Feb 17, 2017

Upgrading packages tends to lead to really broken sets of packages on windows due to file locking, and so I tend to set upgrade = FALSE quite a lot (I would love a remotes.upgrade global option that I could set to FALSE).

If a package installed by remotes::install_github lists a remote in its description then subsequent installations do not honour the upgrade = FALSE argument

@gaborcsardi
Copy link
Contributor

@gaborcsardi gaborcsardi commented Feb 18, 2017

👍

jimhester added a commit to jimhester/remotes that referenced this issue Aug 28, 2018
We now pass all authentication arguments and build arguments to remotes
and dependencies. This means you can supply the authentication
in in the top level `install_()` call and have that same authentication
be used in downstream Remotes.

This also should propagate upgrade to dependencies appropriately, so
setting `upgrade = FALSE` should disable upgrading for all dependencies,
even grandchildren.

Fixes r-lib#86
Fixes r-lib#53
jimhester added a commit to jimhester/remotes that referenced this issue Aug 28, 2018
We now pass all authentication arguments and build arguments to remotes
and dependencies. This means you can supply the authentication
in in the top level `install_()` call and have that same authentication
be used in downstream Remotes.

This also should propagate upgrade to dependencies appropriately, so
setting `upgrade = FALSE` should disable upgrading for all dependencies,
even grandchildren.

Fixes r-lib#86
Fixes r-lib#53
jimhester added a commit to jimhester/remotes that referenced this issue Aug 28, 2018
We now pass all authentication arguments and build arguments to remotes
and dependencies. This means you can supply the authentication
in in the top level `install_()` call and have that same authentication
be used in downstream Remotes.

This also should propagate upgrade to dependencies appropriately, so
setting `upgrade = FALSE` should disable upgrading for all dependencies,
even grandchildren.

Fixes r-lib#53
Fixes r-lib#86
Fixes r-lib#87
jimhester added a commit to jimhester/remotes that referenced this issue Aug 28, 2018
We now pass all authentication arguments and build arguments to remotes
and dependencies. This means you can supply the authentication
in in the top level `install_()` call and have that same authentication
be used in downstream Remotes.

This also should propagate upgrade to dependencies appropriately, so
setting `upgrade = FALSE` should disable upgrading for all dependencies,
even grandchildren.

Fixes r-lib#53
Fixes r-lib#86
Fixes r-lib#87
jimhester added a commit to jimhester/remotes that referenced this issue Aug 29, 2018
We now pass all authentication arguments and build arguments to remotes
and dependencies. This means you can supply the authentication
in in the top level `install_()` call and have that same authentication
be used in downstream Remotes.

This also should propagate upgrade to dependencies appropriately, so
setting `upgrade = FALSE` should disable upgrading for all dependencies,
even grandchildren.

Fixes r-lib#53
Fixes r-lib#86
Fixes r-lib#87
jimhester added a commit that referenced this issue Aug 31, 2018
We now pass all authentication arguments and build arguments to remotes
and dependencies. This means you can supply the authentication
in in the top level `install_()` call and have that same authentication
be used in downstream Remotes.

This also should propagate upgrade to dependencies appropriately, so
setting `upgrade = FALSE` should disable upgrading for all dependencies,
even grandchildren.

Fixes #53
Fixes #86
Fixes #87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants