Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSH External Git Install with *short* SHA Ref fail #674

Open
muschellij2 opened this issue Dec 2, 2021 · 4 comments · May be fixed by #675
Open

SSH External Git Install with *short* SHA Ref fail #674

muschellij2 opened this issue Dec 2, 2021 · 4 comments · May be fixed by #675
Labels
feature a feature request or enhancement

Comments

@muschellij2
Copy link
Contributor

muschellij2 commented Dec 2, 2021 •
edited
Loading

SSH Installs Fine (Just for checking)

This works fine and if the ref is a tag, then it seems to work fine

remotes::install_git("git@github.com:tidyverse/stringr.git", git = "external")
#> Downloading git repo git@github.com:tidyverse/stringr.git
#> '/usr/bin/git' clone --depth 1 --no-hardlinks git@github.com:tidyverse/stringr.git /tmp/RtmpmTPyz6/file59801318d231
#> 
#>      checking for file ‘/tmp/RtmpmTPyz6/file59801318d231/DESCRIPTION’ ...  ✓  checking for file ‘/tmp/RtmpmTPyz6/file59801318d231/DESCRIPTION’ (345ms)
#>   ─  preparing ‘stringr’:
#>      checking DESCRIPTION meta-information ...  ✓  checking DESCRIPTION meta-information
#>   ─  checking for LF line-endings in source and make files and shell scripts
#>   ─  checking for empty or unneeded directories
#>   ─  building ‘stringr_1.4.0.9000.tar.gz’
#>      
#> 
#> Installing package into '/home/jupyter/.R/library'
#> (as 'lib' is unspecified)
remotes::install_git("git@github.com:tidyverse/stringr.git", 
                     ref = "stringr-0.2", git = "external")
#> Downloading git repo git@github.com:tidyverse/stringr.git
#> '/usr/bin/git' clone --depth 1 --no-hardlinks git@github.com:tidyverse/stringr.git /tmp/RtmpmTPyz6/file598033d5f100
#> '/usr/bin/git' fetch origin stringr-0.2
#> '/usr/bin/git' checkout FETCH_HEAD
#> 
#>      checking for file ‘/tmp/RtmpmTPyz6/file598033d5f100/DESCRIPTION’ ...  ✓  checking for file ‘/tmp/RtmpmTPyz6/file598033d5f100/DESCRIPTION’
#>   ─  preparing ‘stringr’:
#>      checking DESCRIPTION meta-information ...  ✓  checking DESCRIPTION meta-information
#>   ─  checking for LF line-endings in source and make files and shell scripts
#>   ─  checking for empty or unneeded directories
#>   ─  creating default NAMESPACE file
#> ─  building ‘stringr_0.2.tar.gz’
#>      
#> 
#> Installing package into '/home/jupyter/.R/library'
#> (as 'lib' is unspecified)

SHA

Using an SHA - fails. I believe this is due to depth, but unsure, still working it out. Can confirm tidyverse/stringr@dd909b7 exists.

remotes::install_git("git@github.com:tidyverse/stringr.git@dd909b7", git = "external")
#> Downloading git repo git@github.com:tidyverse/stringr.git
#> '/usr/bin/git' clone --depth 1 --no-hardlinks git@github.com:tidyverse/stringr.git /tmp/RtmpmTPyz6/file5980644511a7
#> '/usr/bin/git' fetch origin dd909b7
#> Warning in system(full, intern = TRUE, ignore.stderr = quiet): running command
#> ''/usr/bin/git' fetch origin dd909b7' had status 128
#> Error : Command failed (128)
remotes::install_git("git@github.com:tidyverse/stringr.git", ref = "dd909b7", git = "external")
#> Downloading git repo git@github.com:tidyverse/stringr.git
#> '/usr/bin/git' clone --depth 1 --no-hardlinks git@github.com:tidyverse/stringr.git /tmp/RtmpmTPyz6/file59801d9d0be2
#> '/usr/bin/git' fetch origin dd909b7
#> Warning in system(full, intern = TRUE, ignore.stderr = quiet): running command
#> ''/usr/bin/git' fetch origin dd909b7' had status 128
#> Error : Command failed (128)
/usr/bin/git --version
git version 2.20.1

Created on 2021-12-02 by the reprex package (v2.0.1)

Session info 
sessioninfo::session_info()
#> ─ Session info  ──────────────────────────────────────────────────────────────
#>  hash: carousel horse, waving hand: medium-dark skin tone, transgender symbol
#> 
#>  setting  value
#>  version  R version 4.1.2 (2021-11-01)
#>  os       Debian GNU/Linux 10 (buster)
#>  system   x86_64, linux-gnu
#>  ui       X11
#>  language (EN)
#>  collate  C.UTF-8
#>  ctype    C.UTF-8
#>  tz       Etc/UTC
#>  date     2021-12-02
#>  pandoc   2.14.0.2 @ /opt/conda/bin/ (via rmarkdown)
#> 
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  ! package     * version    date (UTC) lib source
#>    callr         3.7.0      2021-04-20 [2] CRAN (R 4.1.0)
#>    cli           3.1.0.9000 2021-10-29 [1] Github (r-lib/cli@1af3d91)
#>    crayon        1.4.2      2021-10-29 [1] CRAN (R 4.1.0)
#>    curl          4.3.2      2021-06-23 [1] CRAN (R 4.1.0)
#>    digest        0.6.28     2021-09-23 [1] CRAN (R 4.1.0)
#>    evaluate      0.14       2019-05-28 [2] CRAN (R 4.1.0)
#>    fastmap       1.1.0      2021-01-25 [2] CRAN (R 4.1.0)
#>    fs            1.5.1      2021-11-30 [1] CRAN (R 4.1.0)
#>    glue          1.5.1      2021-11-30 [1] CRAN (R 4.1.0)
#>    highr         0.9        2021-04-16 [2] CRAN (R 4.1.0)
#>    htmltools     0.5.2      2021-08-25 [1] CRAN (R 4.1.0)
#>    knitr         1.36       2021-09-29 [1] CRAN (R 4.1.0)
#>    magrittr      2.0.1      2020-11-17 [2] CRAN (R 4.1.0)
#>    pkgbuild      1.2.1      2021-11-30 [1] CRAN (R 4.1.0)
#>    prettyunits   1.1.1      2020-01-24 [2] CRAN (R 4.1.0)
#>    processx      3.5.2      2021-04-30 [2] CRAN (R 4.1.0)
#>    ps            1.6.0      2021-02-28 [2] CRAN (R 4.1.0)
#>    R6            2.5.1      2021-08-19 [1] CRAN (R 4.1.0)
#>    remotes       2.4.2      2021-12-02 [1] Github (r-lib/remotes@fcad17b)
#>    reprex        2.0.1      2021-08-05 [1] CRAN (R 4.1.0)
#>    rlang         0.4.12     2021-10-18 [1] CRAN (R 4.1.0)
#>    rmarkdown     2.11       2021-09-14 [1] CRAN (R 4.1.0)
#>    rprojroot     2.0.2      2020-11-15 [2] CRAN (R 4.1.0)
#>    rstudioapi    0.13       2020-11-12 [2] CRAN (R 4.1.0)
#>    sessioninfo   1.1.1.9000 2021-11-30 [1] Github (muschellij2/sessioninfo@6e2857d)
#>    stringi       1.7.6      2021-11-29 [1] CRAN (R 4.1.0)
#>  V stringr       1.4.0      2021-12-02 [1] xgit (git@github.com:tidyverse/stringr.git@d32c3d9) (on disk 0.2)
#>    withr         2.4.3      2021-11-30 [1] CRAN (R 4.1.0)
#>    xfun          0.28       2021-11-04 [1] CRAN (R 4.1.0)
#>    yaml          2.2.1      2020-02-01 [2] CRAN (R 4.1.0)
#> 
#>  [1] /home/jupyter/.R/library
#>  [2] /usr/local/lib/R/site-library
#>  [3] /usr/lib/R/site-library
#>  [4] /usr/lib/R/library
#> 
#>  V ── Loaded and on-disk version mismatch.
#> 
#> ──────────────────────────────────────────────────────────────────────────────
@muschellij2 muschellij2 linked a pull request Dec 2, 2021 that will close this issue
Open
@gaborcsardi
Copy link
Member

gaborcsardi commented Dec 2, 2021 •
edited
Loading

Using the full SHA works, though:

remotes::install_git(
  "git@github.com:tidyverse/stringr.git@dd909b714b20ff3add2eedb0a1c917ba6938e40e",
  git = "external"
)

Isn't this good enough?

@muschellij2
Copy link
Contributor Author 

remotes::install_git("git@github.com:tidyverse/stringr.git@dd909b7", git = "external")
#> Downloading git repo git@github.com:tidyverse/stringr.git
#> '/usr/bin/git' clone --depth 1 --no-hardlinks git@github.com:tidyverse/stringr.git /tmp/RtmpKlz895/file743a4ed8c6e6
#> '/usr/bin/git' fetch origin dd909b7
#> Warning in system(full, intern = TRUE, ignore.stderr = quiet): running command
#> ''/usr/bin/git' fetch origin dd909b7' had status 128
#> Error : Command failed (128)
remotes::install_git("git@github.com:tidyverse/stringr.git@dd909b714b20ff3add2eedb0a1c917ba6938e40e", git = "external")
#> Downloading git repo git@github.com:tidyverse/stringr.git
#> '/usr/bin/git' clone --depth 1 --no-hardlinks git@github.com:tidyverse/stringr.git /tmp/RtmpKlz895/file743a1c306a17
#> '/usr/bin/git' fetch origin dd909b714b20ff3add2eedb0a1c917ba6938e40e
#> '/usr/bin/git' checkout FETCH_HEAD
#> 
#>      checking for file ‘/tmp/RtmpKlz895/file743a1c306a17/DESCRIPTION’ ...  ✓  checking for file ‘/tmp/RtmpKlz895/file743a1c306a17/DESCRIPTION’
#>   ─  preparing ‘stringr’:
#>      checking DESCRIPTION meta-information ...  ✓  checking DESCRIPTION meta-information
#>   ─  checking for LF line-endings in source and make files and shell scripts
#>   ─  checking for empty or unneeded directories
#>   ─  building ‘stringr_1.4.0.9000.tar.gz’
#>      
#> 
#> Installing package into '/home/jupyter/.R/library'
#> (as 'lib' is unspecified)

Created on 2021-12-02 by the reprex package (v2.0.1)

Session info 
sessioninfo::session_info()
#> ─ Session info  ──────────────────────────────────────────────────────────────
#>  hash: woman: medium-light skin tone, red hair, vampire: dark skin tone, exploding head
#> 
#>  setting  value
#>  version  R version 4.1.2 (2021-11-01)
#>  os       Debian GNU/Linux 10 (buster)
#>  system   x86_64, linux-gnu
#>  ui       X11
#>  language (EN)
#>  collate  C.UTF-8
#>  ctype    C.UTF-8
#>  tz       Etc/UTC
#>  date     2021-12-02
#>  pandoc   2.14.0.2 @ /opt/conda/bin/ (via rmarkdown)
#> 
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package     * version    date (UTC) lib source
#>  callr         3.7.0      2021-04-20 [2] CRAN (R 4.1.0)
#>  cli           3.1.0.9000 2021-10-29 [1] Github (r-lib/cli@1af3d91)
#>  crayon        1.4.2      2021-10-29 [1] CRAN (R 4.1.0)
#>  curl          4.3.2      2021-06-23 [1] CRAN (R 4.1.0)
#>  digest        0.6.28     2021-09-23 [1] CRAN (R 4.1.0)
#>  evaluate      0.14       2019-05-28 [2] CRAN (R 4.1.0)
#>  fastmap       1.1.0      2021-01-25 [2] CRAN (R 4.1.0)
#>  fs            1.5.1      2021-11-30 [1] CRAN (R 4.1.0)
#>  glue          1.5.1      2021-11-30 [1] CRAN (R 4.1.0)
#>  highr         0.9        2021-04-16 [2] CRAN (R 4.1.0)
#>  htmltools     0.5.2      2021-08-25 [1] CRAN (R 4.1.0)
#>  knitr         1.36       2021-09-29 [1] CRAN (R 4.1.0)
#>  lifecycle     1.0.1      2021-09-24 [1] CRAN (R 4.1.0)
#>  magrittr      2.0.1      2020-11-17 [2] CRAN (R 4.1.0)
#>  pkgbuild      1.2.1      2021-11-30 [1] CRAN (R 4.1.0)
#>  prettyunits   1.1.1      2020-01-24 [2] CRAN (R 4.1.0)
#>  processx      3.5.2      2021-04-30 [2] CRAN (R 4.1.0)
#>  ps            1.6.0      2021-02-28 [2] CRAN (R 4.1.0)
#>  R6            2.5.1      2021-08-19 [1] CRAN (R 4.1.0)
#>  remotes       2.4.2      2021-12-02 [1] Github (r-lib/remotes@fcad17b)
#>  reprex        2.0.1      2021-08-05 [1] CRAN (R 4.1.0)
#>  rlang         0.4.12     2021-10-18 [1] CRAN (R 4.1.0)
#>  rmarkdown     2.11       2021-09-14 [1] CRAN (R 4.1.0)
#>  rprojroot     2.0.2      2020-11-15 [2] CRAN (R 4.1.0)
#>  rstudioapi    0.13       2020-11-12 [2] CRAN (R 4.1.0)
#>  sessioninfo   1.1.1.9000 2021-11-30 [1] Github (muschellij2/sessioninfo@6e2857d)
#>  stringi       1.7.6      2021-11-29 [1] CRAN (R 4.1.0)
#>  stringr       1.4.0.9000 2021-12-02 [1] xgit (git@github.com:tidyverse/stringr.git@dd909b7)
#>  vctrs         0.3.8      2021-04-29 [2] CRAN (R 4.1.0)
#>  withr         2.4.3      2021-11-30 [1] CRAN (R 4.1.0)
#>  xfun          0.28       2021-11-04 [1] CRAN (R 4.1.0)
#>  yaml          2.2.1      2020-02-01 [2] CRAN (R 4.1.0)
#> 
#>  [1] /home/jupyter/.R/library
#>  [2] /usr/local/lib/R/site-library
#>  [3] /usr/lib/R/site-library
#>  [4] /usr/lib/R/library
#> 
#> ──────────────────────────────────────────────────────────────────────────────

@muschellij2
Copy link
Contributor Author

Yeah I just saw that. I am using sessioninfo::package_info to get deps, so I guess I gotta get the full one. OK - good to close and kill the PR (maybe a warning with short SHAs?)

@gaborcsardi
Copy link
Member

gaborcsardi commented Dec 2, 2021 •
edited
Loading

I like the idea of warning for short SHAs for (x)git remotes.

It would be great to make the short SHAs work, but deep cloning can also be really bad for bug repos.

I'll reopen this for adding the warning.

@muschellij2 muschellij2 changed the title SSH External Git Install with SHA Ref ail SSH External Git Install with *short* SHA Ref fail Dec 2, 2021
@gaborcsardi gaborcsardi reopened this Dec 2, 2021
@gaborcsardi gaborcsardi added the feature a feature request or enhancement label Dec 2, 2021
@muschellij2 muschellij2 mentioned this issue Dec 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unadvertised SHAs don't work for github/bitbucket muschellij2/remotes
2 participants
@gaborcsardi @muschellij2