Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate lazyeval #77

Merged
merged 2 commits into from Jan 8, 2022
Merged

Eliminate lazyeval #77

merged 2 commits into from Jan 8, 2022

Conversation

hadley
Copy link
Member

@hadley hadley commented Jan 8, 2022

This isn't perfectly correct, but I think it's extremely unlikely to cause any problems for typical usage of rex, and it keeps the dependencies minimal.

Fixes #75

@hadley
Eliminate lazyeval
30e28e4 
This isn't perfectly correct, but I think it's extremely unlikely to cause any problems for typical usage of rex, and it keeps the dependencies minimal.

Fixes r-lib#75
@hadley
Merged upstream/master into remove-lazyeval
9817616
@hadley
Copy link
Member Author

hadley commented Jan 8, 2022

The problem is that it evaluates all elements of ... in the parent.frame() of rex, which is technically incorrect, but you should only see the problem if you're passing ... through multiple functions (the first case of https://adv-r.hadley.nz/evaluation.html#programming-with-subset).

@kevinushey kevinushey merged commit c557731 into r-lib:master Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove {lazyeval}
2 participants
@hadley @kevinushey