Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use anyNA and negate after logical aggregation #89

Merged
merged 1 commit into from Sep 13, 2023

Conversation

MichaelChirico
Copy link
Contributor

Finishing the pass of low-hanging/obvious fruit from {lintr}.

I would also suggest maybe not using gettextf() if {rex} doesn't have any translations? stop(sprintf(...)) may be simpler to follow.

Copy link
Collaborator

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevinushey kevinushey merged commit 925a4d1 into r-lib:main Sep 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants