env_clone() does not reproduce active bindings faithfully

[tmastny]

Below is the reprex. It seems that eval_tidy returns the binding function, while eval returns the result of the function.

Is this the desired behavior?

library(rlang)
e <- new.env()
e$y <- 1
env_bind_fns(e, y = function(val) {print("getting called"); 1})
eval(expr(y), e)
#> [1] "getting called"
#> [1] 1
eval_tidy(expr(y), e)
#> function(val) {print("getting called"); 1}
eval_tidy(expr(y()), e)
#> [1] "getting called"
#> [1] 1

Created on 2018-07-24 by the reprex
package (v0.2.0).

[lionel-]

That's because environments are cloned and env_clone() loses the binding info.

I'm thinking about deprecating environments, you'd have to pass a data mask built with new_data_mask() instead. Then there would be no cloning.