Allow %|% to work when y is of same length as x #806
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow
x %|% y
wheny
is of same length asx
. For example:Changes:
R/operators.R
: I modified the documentation of %|% to reflect the changes in behaviour of this function. I also modified thestopifnot()
checks accordingly.src/lib/replace-na.c
: Rather than looking at the length ofy
inreplace_na_()
, I created a separate functionreplace_na_vec_()
and call the correct function depending on the length ofy
, as not to sacrifice speed by having more if/else statements.tests/testthat/test-operators.R
: I added tests to check whetherx %|% y
is working correctly whenlength(y) == length(x)
, and also that it produces an error when it is not.