Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reticulate errors in cnd_type() (fixes #1664) #1693

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gergness
Copy link

Not sure if this is the right way to fix, but was useful enough for me for that I thought I'd share.

reticulate stores it's conditions with the right classes to work with rlang, but uses an environment instead of a list.

err <- try(reticulate::py_run_string("oops"), silent = TRUE) |> attr("condition")

is.environment(err)
#> [1] TRUE
class(err)
#> [1] "python.builtin.NameError"     "python.builtin.Exception"    
#> [3] "python.builtin.BaseException" "python.builtin.object"       
#> [5] "error"                        "condition"

Created on 2024-02-22 with reprex v2.1.0

@@ -100,7 +100,8 @@ void r_interrupt(void) {

enum r_cnd_type r_cnd_type(r_obj* cnd) {
r_obj* classes = r_class(cnd);
if (r_typeof(cnd) != R_TYPE_list ||
if (
Copy link
Member

@lionel- lionel- May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this will cause R to crash if the caller assumes (rightfully IMO) that a condition is a list. Note that the code modified here is part of a C-level API used in multiple packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants