Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that aliases should be space separated (not comma). #1627

Closed
wants to merge 1 commit into from

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Jun 7, 2024

Fix #1626. I have seen in the wild cases of persons who used commas for example.

r-spatial/sf#2285

See the defunct file https://github.com/r-spatial/sf/pull/2285/files#diff-089405beae4488e32546bbf6c68166873b65f29323ca65f621de30eb80154e53 as an example.

@olivroy olivroy marked this pull request as ready for review June 7, 2024 07:40
@hadley
Copy link
Member

hadley commented Jun 27, 2024

Hmmmm, I'd rather encourage people to put one alias on each line.

@hadley hadley closed this Jul 9, 2024
@olivroy olivroy deleted the alias branch July 9, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document that aliases should be documented 1 per line
2 participants