Parse R files in collation order #381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 1, 2015 21:10
the paths returned by r_files() are absolute -- probably source_package() was broken before
|
@Geoff99: Sorry, I completely missed that one. I was searching for "collation", and your contributions slipped through. |
|
No worries @krlmlr Just wanted to save some work if possible. No guarantee the way I "fixed' the parse in collation order issue is the best one. Happy with any approach that solves it. Best Geoff |
|
Thanks, @Geoff99, you definitely did save work. Your patch is virtually identical to mine, except for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that the order of documentation that comes from multiple files can be controlled
Looks like package_files() and probably also source_package() was broken before, because r_paths() returns absolute paths. Need to investigate.
@hadley: Do you like the idea?