Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow more than one given name in Authors@R #672

Merged
merged 5 commits into from Oct 3, 2017
Merged

Allow more than one given name in Authors@R #672

merged 5 commits into from Oct 3, 2017

Commits on Oct 2, 2017

  1. Allow more than one given name in Authors@R 

    The Authors@R field in the DESCRIPTION file uses the `person` class for
managing the authors. If a author has more than one given name
`roxygenise` failed with an error in `package_authors`:

    Error in vapply(unclass(authors), author_desc, character(1)) :
        values must be length 1,
    but FUN(X[[1]]) result is length 2

This commit concatenates all given names separated by a space to solve
this error. For most western cultures that should be fine. Unfortunately
I don't know anything about other naming schemes.
    @sgibb
    sgibb committed Oct 2, 2017
    Copy the full SHA
    a44b6b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2017

  1. Allow multiple family names

    @sgibb
    sgibb committed Oct 3, 2017
    Copy the full SHA
    424e424 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary tests and fix styling

    @sgibb
    sgibb committed Oct 3, 2017
    Copy the full SHA
    57ec15e View commit details
    Browse the repository at this point in the history

  3. Fix indention

    @sgibb
    sgibb committed Oct 3, 2017
    Copy the full SHA
    d39f048 View commit details
    Browse the repository at this point in the history

  4. Add NEWS entry for PR #672

    @sgibb
    sgibb committed Oct 3, 2017
    Copy the full SHA
    0f85493 View commit details
    Browse the repository at this point in the history