Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rray_mean() edge case #179

Open
DavisVaughan opened this issue May 19, 2019 · 3 comments
Open

Fix rray_mean() edge case #179

DavisVaughan opened this issue May 19, 2019 · 3 comments
Labels
bug 🐛 an unexpected problem or unintended behavior

Comments

@DavisVaughan
Copy link
Member 

x <- matrix(numeric(), 0, 2)
rray_mean(x, 2L)

this crashes, when it should give (0, 2) -> (0, 1) so a (0, 1) numeric matrix
@DavisVaughan
Copy link
Member Author

There is a commented out test for this in test-reducers.R

@DavisVaughan DavisVaughan added blocked 🙅‍♂️ bug 🐛 an unexpected problem or unintended behavior labels May 24, 2019
@DavisVaughan
Copy link
Member Author

xtensor-stack/xtensor#1625

@DavisVaughan
Copy link
Member Author

DavisVaughan commented Aug 31, 2019 •
edited
Loading

No longer blocked, but would require dev xtensor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DavisVaughan