Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review dependencies #118

Closed
hadley opened this issue Jun 1, 2018 · 7 comments · Fixed by #143
Closed

Review dependencies #118

hadley opened this issue Jun 1, 2018 · 7 comments · Fixed by #143
Assignees
Labels
feature a feature request or enhancement

Comments

@hadley
Copy link
Member

hadley commented Jun 1, 2018

What is the full set of recursive dependencies? Is there any obvious way to reduce?

@hadley
Copy link
Member Author

hadley commented Jun 29, 2018

@dpseidel can you please take a stab at this one? Start by using some existing tool (ask @gaborcsardi) to enumerate all the recursive deps, and list in this issue

@hadley hadley added the feature a feature request or enhancement label Jun 29, 2018
@dpseidel dpseidel self-assigned this Jun 29, 2018
@dpseidel
Copy link
Collaborator

dpseidel commented Jul 5, 2018

Depends/Imports/LinkingTo (nested):

  • R >=2.13
  • RColorBrewer-1.1-2
  • dichromat-2.0-0
    • stats
  • plyr-1.8.4
    • R >= 3.1.0
    • Rcpp-0.12.17 >= 0.11.0
  • munsell-0.5.0
    • methods
    • colorspace-1.3-2
      - graphics
      - grDevices
  • labeling-0.3
  • Rcpp-0.12.17
  • R6-2.2.2
    • R >= 3.0.0
  • viridisLite-0.3.0

So in total, scales is dependent on 9 packages beyond those shipped with baseR.
Parsed from http://crandeps.r-pkg.org/deps/scales

@hadley
Copy link
Member Author

hadley commented Jul 5, 2018

And we eliminated plyr already.

I wonder if we should move dichromat and labeling to suggested? They seem less frequently used.

@dpseidel
Copy link
Collaborator

dpseidel commented Jul 5, 2018

sure, do you want me to just make the change? is there a tool to test how frequently a dependency is used?

@hadley
Copy link
Member Author

hadley commented Jul 5, 2018

I think the main thing is to check that ggplot2's use of scales doesn't end up using the functions that require these packages (I don't think it does, but you should check).

You could try a GitHub code search for the functions involved (dichromat_pal() and extended_breaks()). That would give a rough idea of popularity.

@dpseidel
Copy link
Collaborator

dpseidel commented Jul 5, 2018

Moving dichromat to suggests seems fine, but ggplot2 relies on extended_breaks() by default since 2012 (ggplot2 issue 580) so labeling is required for basically every plot.

@hadley
Copy link
Member Author

hadley commented Jul 5, 2018

Ah, ok, lets just suggest dichromat 😄

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants