Fix R6 inheritance #170
Merged
Fix R6 inheritance #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add a unit test too? |
|
Added! Good thing too! They helped me catch another bug -- test-based development for the win! 🏆 |
|
Is probably now deserving of a news bullet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to covert ggplot2 to use scales exported
Rangeobjects (tidyverse/ggplot2#2710), I realized that the R6 inheritance was broken. This PR fixes that. Unfortunately this likely means that conversion in ggplot2 needs to wait until the next scales release.