Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI builds keep failing #46

Closed
lorenzwalthert opened this issue Jun 22, 2017 · 28 comments
Closed

CI builds keep failing #46

lorenzwalthert opened this issue Jun 22, 2017 · 28 comments

Comments

@lorenzwalthert
Copy link
Collaborator

lorenzwalthert commented Jun 22, 2017

Since I added pkgload, all builds keep failing. Also see #43. You can see the history here. Travis builds don't fail. I was wondering why. The error is also not always the same. It is either
after trying to install r-pkgs/callr (which should actually be r-lib/callr) or r-pkgs/pkgbuild. Maybe it is due to the wrongly specified dependencies in pkgload with r-ib / r-pkgs, so I created two PRs for
pkgbuild and pkgload to fix the DESCRIPTION file. It might be unrelated though since Travis does not fail.

@krlmlr
Copy link
Member

krlmlr commented Jun 22, 2017

Thanks. The r-pkgs queries should be forwarded to r-lib, but it's good to have it corrected. Looking into AppVeyor failures.

@krlmlr
Copy link
Member

krlmlr commented Jun 30, 2017

Seems we need to wait for r-lib/remotes#41.

@lorenzwalthert
Copy link
Collaborator Author

Now we even have failing travis builds. Seems related to tic, as it says devtools is missing for deployment.

@lorenzwalthert lorenzwalthert changed the title appveyor builds keep failing CI builds keep failing Jul 2, 2017
@krlmlr
Copy link
Member

krlmlr commented Jul 2, 2017

Yes, we need to replace devtools with pkgload in the README.Rmd file and also fix the code, because it's rendered for tags.

@lorenzwalthert
Copy link
Collaborator Author

The appveyor build keeps failing, this time due to the remote dependencyutf8. Isn't tic installing the remote dependencies?

@lorenzwalthert
Copy link
Collaborator Author

travis also keeps failing, probably also a tic issue.

@krlmlr
Copy link
Member

krlmlr commented Jul 10, 2017

I fixed the build to create the pkgdown only for tags, and fixed tic to install the package in a temporary library before building the pkgdown. Let's see.

@krlmlr
Copy link
Member

krlmlr commented Jul 10, 2017

I've also looked into fixing AppVeyor.

@lorenzwalthert
Copy link
Collaborator Author

lorenzwalthert commented Jul 10, 2017

Cool, now it seems all builds pass and the badges are correct. Minus one issue. Thanks @krlmlr 😊

@krlmlr
Copy link
Member

krlmlr commented Jul 11, 2017

Yeah, but we need to keep an eye on these tests, because they seem to be too forgiving now.

@lorenzwalthert
Copy link
Collaborator Author

We currently have failing travis builds due to a vignette build error

Error in loadVignetteBuilder(vigns$pkgdir) :
vignette builder 'knitr' not found
Calls: -> loadVignetteBuilder

Same problem occurs in my fork.

A failing travis build probably due to wrong R internals version. It was suggested to simply empty the cache for pre-installed packages.

@krlmlr any ideas why these, in particular the first problem, occur? Also, can you grant me admin rights to the appveyor CI?

@krlmlr
Copy link
Member

krlmlr commented May 16, 2018

Can you try removing the cache setting in appveyor.yml? I'm not sure how to grant you admin access, now the package is part of the r-lib organization.

@lorenzwalthert
Copy link
Collaborator Author

Ok, did so and pushed to my fork so we can try there before pushing to upstream.

@lorenzwalthert
Copy link
Collaborator Author

Any idea about the first problem? Should I try an older version of tic?

@krlmlr
Copy link
Member

krlmlr commented May 16, 2018

Not sure. Can you adapt tic.R to show an info about installed packages in the before_script stage?

@lorenzwalthert
Copy link
Collaborator Author

lorenzwalthert commented May 16, 2018 via email

@krlmlr
Copy link
Member

krlmlr commented May 16, 2018

Very strange, knitr seems to be installed indeed. No idea, perhaps this issue will vanish if we wait a few days?

@lorenzwalthert
Copy link
Collaborator Author

Ok. Just re-triggered the build and it's now only failing for R versions before current release.

@lorenzwalthert
Copy link
Collaborator Author

Ok, appveyor removing the cache worked. 😊 Will try the same with travis.

@krlmlr
Copy link
Member

krlmlr commented May 22, 2018

Seeing this in dplyr now. Debugging the job on Travis to see what's going on.

@krlmlr
Copy link
Member

krlmlr commented May 22, 2018

@gaborcsardi: This looks like an rcmdcheck problem: On R 3.3 (tested in a Travis session) and earlier (not yet tested), rcmdcheck::rcmdcheck() can't find the vignette builder even though it's installed. Does this ring a bell?

Working on replicating the problem locally.

@gaborcsardi
Copy link
Member

rcmdcheck just calls R CMD check, so I am not sure why this should happen. It does juggle with environment variables, etc. so I am not saying it is impossible.

@krlmlr
Copy link
Member

krlmlr commented May 22, 2018

Can't replicate locally. Noticed that Travis CI has R_LIBS_USER set to the path for cached packages, and R 3.3 puts this path last in .libPaths().

I'll resume debugging in Travis CI tomorrow.

@lorenzwalthert
Copy link
Collaborator Author

👍 thanks.

@lorenzwalthert
Copy link
Collaborator Author

@lorenzwalthert
Copy link
Collaborator Author

Closed for now with #407.

@lorenzwalthert
Copy link
Collaborator Author

lorenzwalthert commented Oct 31, 2018

It seems as there is a new error on travis when trying to install a package is not available for a certain R version.

Error: (converted from warning) package ‘DiagrammeR’ is not available (for R version 3.1.3)

How should we handle this? @krlmlr any experience from tibble or dplyr with it?

@lorenzwalthert
Copy link
Collaborator Author

FYI: For everyone else who watches this repo and who does not want to get notifications about this issue (or any other issue), you can mute individual issues on the right side of the page, below the labels. This issue is likely to be closed and opened a few times in the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants