Delete cache directories if empty #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
skip check on CRAN, since on Windows, temp dir is different during R CMD CHECK
lorenzwalthert
requested review from
IndrajeetPatil
and removed request for
IndrajeetPatil
… every operating system
This comment was marked as outdated.
This comment was marked as outdated.
|
We're a bit under time pressure for this release as per #1118 so I just use my admin priviledges to merge now. Feel free to review later. |
|
Sorry, @lorenzwalthert, for not having a look at the PR in time. Open source is currently a low priority for me until I find a job, so I might not be as responsive as I used to be. |
|
Sure, I understand that. All the best with your job search in the mean time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1118. In R CMD Check, oldrel 4 now errors on warning only, since
tools::R_user_dir()was only added to R later than in R version 3.6.