Clarify labelling strategy #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzwalthert
force-pushed
the
github
branch
from
ac6a9b6
to
c46ef2a
Compare
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
=======================================
Coverage 92.17% 92.17%
=======================================
Files 28 28
Lines 1188 1188
=======================================
Hits 1095 1095
Misses 93 93Continue to review full report at Codecov.
|
krlmlr
approved these changes
Nov 21, 2017
There was a problem hiding this comment.
Thanks. Closing unresolved issues has an important downside I forgot: When searching for issues, it's difficult to filter for closed-but-unresolved issues. (But it's easy to filter for open issues.) We might want to revisit later (and maybe reopen the resolved issues after CRAN release)m, but it's fine for now.
|
Yes, that's right. Yes we may want to change the policy after the CRAN release. |
krlmlr
added a commit
that referenced
this pull request
Nov 27, 2017
- Adapt documentation (#290). - Add roundtrip (#287). - Fix AppVeyor builds. - Fix token insertion / comment interaction (#279). - Clarify labelling strategy (#285). - Fixing and extending Rstudioaddins (#283). - Fix eq assign parsing (#276). - style_files -> vectorized style_file (#273). - Refactoring (#270). - Fix CI (#275). - Fix covr (#274). - Renaming files (#271). - Handle styling of an unsaved active file (#243). - Test R 3.1 and R 3.2 (#249). - Allow empty {} without line break (#261). - Wrap expr in expr before enclosing with curly braces (#263). - Avoid checking for hard-coded dot (#262). - Account for dependency renaming (utf8 changed to enc) (#264). - Indention of function declaration and closing braces (#260). - Only remove line break before closing with strict option (#252).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #284. @krlmlr I created saamwerk and described the labelling strategy there since I think it might be useful in other places too. I hope that's ok with you. I think it would be nice to integrate these recommendations in some existing open source and I tried https://opensource.guide but they don't accept self nominations. Any ideas where I could try to submit?