Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comments in pipe and assignment sequence while maintaining correct indention #482

Merged
merged 1 commit into from Mar 11, 2019

Conversation

@lorenzwalthert
Copy link
Collaborator

commented Mar 11, 2019

Closes #481. There might be a couple of other problems lurking in the code that are related to looking for the next and previous non-comment token instead of simply the next token. Some of them have been found already in the past.

@lorenzwalthert lorenzwalthert merged commit 31d6ac5 into r-lib:master Mar 11, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lorenzwalthert lorenzwalthert changed the title allow comments in pipe and assignment without causing indention to fail Allow comments in pipe and assignment sequence while maintaining correct indention Mar 11, 2019

@lorenzwalthert lorenzwalthert deleted the lorenzwalthert:pipe-comment-assignment branch Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.