Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turning off styling for an individual rmd chunk #790

merged 2 commits into from May 3, 2021


Copy link

@lorenzwalthert lorenzwalthert commented May 2, 2021

Closes #781.

Here is how the current PR would change benchmark results when merged into master:

  • cache_applying: 0.07 -> 0.09 (41.7%)
  • cache_recording: 1.08 -> 1.1 (2%)
  • without_cache: 2.85 -> 2.81 (-1.3%)

A bit annoying but applying the cache on Rmd documents is now significantly slower since we don't cache the whole file input and hence the added code from this PR has to run evey time. Since 0.1s is still almost instant, it's fine.

Copy link

Codecov Report

Merging #790 (deebffc) into master (85435e3) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #790      +/-   ##
+ Coverage   90.40%   90.45%   +0.04%     
  Files          47       47              
  Lines        2419     2430      +11     
+ Hits         2187     2198      +11     
  Misses        232      232              
Impacted Files Coverage Δ
R/transform-code.R 92.72% <100.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85435e3...deebffc. Read the comment docs.

@lorenzwalthert lorenzwalthert merged commit 74f79ae into r-lib:master May 3, 2021
@lorenzwalthert lorenzwalthert deleted the issue-781 branch May 3, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Disable styler for knitr R code chunk
2 participants