Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only remove excessive line breaks in assignments #809

merged 2 commits into from Jun 9, 2021


Copy link

Closes #808.

Copy link

Glad it was an easy fix! LGTM

Copy link

Codecov Report

Merging #809 (4a74bfe) into master (9d376c4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #809   +/-   ##
  Coverage   90.46%   90.46%           
  Files          47       47           
  Lines        2433     2433           
  Hits         2201     2201           
  Misses        232      232           
Impacted Files Coverage Δ
R/rules-line-breaks.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d376c4...4a74bfe. Read the comment docs.

Copy link

github-actions bot commented Jun 8, 2021

This is how benchmark results would change (along with a 95% confience interval in relative change) if e408eef is merged into master:

  • cache_applying: 0.06s -> 0.06s [-3.34%, +2.94%]
  • cache_recording: 1.48s -> 1.47s [-1.7%, +0.83%]
  • without_cache: 3.89s -> 3.87s [-1.76%, +0.45%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert merged commit 00125f0 into r-lib:master Jun 9, 2021
@lorenzwalthert lorenzwalthert deleted the issue-808 branch June 9, 2021 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Unwrapping multiple assignments -- intended change?
3 participants