Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double negation in skip_if_not() message #1247

Closed
dpprdan opened this issue Nov 26, 2020 · 1 comment · Fixed by #1250
Closed

double negation in skip_if_not() message #1247

dpprdan opened this issue Nov 26, 2020 · 1 comment · Fixed by #1250
Labels
bug an unexpected problem or unintended behavior skip wip work in progress

Comments

@dpprdan
Copy link
Contributor

dpprdan commented Nov 26, 2020

The message in skip_if_not() is always appended with " is not TRUE". This makes sense for the deparse(substitute(condition)) default. It may not for custom messages.

Case in point is the googledrive package, where skip_if_not(drive_has_token(), "No Drive token") results in "No Drive token is not TRUE".

This can be easily fixed IMHO if skip_if_not() is modelled after skip_if(), i.e. if custom messages are shown as is and only the default message is "{condition} is not TRUE".

I can make a PR, if you agree.

@hadley
Copy link
Member

hadley commented Nov 30, 2020

Yeah, agreed, and a PR would be great 😄

@hadley hadley added bug an unexpected problem or unintended behavior skip wip work in progress labels Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior skip wip work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants