You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The message in skip_if_not() is always appended with " is not TRUE". This makes sense for the deparse(substitute(condition)) default. It may not for custom messages.
Case in point is the googledrive package, where skip_if_not(drive_has_token(), "No Drive token")results in "No Drive token is not TRUE".
This can be easily fixed IMHO if skip_if_not() is modelled after skip_if(), i.e. if custom messages are shown as is and only the default message is "{condition} is not TRUE".
I can make a PR, if you agree.
The text was updated successfully, but these errors were encountered:
The
message
inskip_if_not()
is always appended with " is not TRUE". This makes sense for thedeparse(substitute(condition))
default. It may not for custom messages.Case in point is the googledrive package, where
skip_if_not(drive_has_token(), "No Drive token")
results in "No Drive token is not TRUE".This can be easily fixed IMHO if
skip_if_not()
is modelled afterskip_if()
, i.e. if custom messages are shown as is and only the default message is "{condition} is not TRUE".I can make a PR, if you agree.
The text was updated successfully, but these errors were encountered: