describe_it() should set the test_code() reporter like test_that()

[DavisVaughan]

testthat/R/describe.R

Line 76 in 4076b66

describe_it <- function(description, code, env = parent.frame()) {

In bench there is this test, which I can't run interactively:

describe("bench_time", {
  skip_on_cran()
  skip_on_ci()

  res <- bench_time(1 + 1:1e7)
  it("returns process and real time", {
    expect_equal(names(res), c("process", "real"))
  })
  # snip...
})

The problem is that local_interactive_reporter() isn't set up, which is what sets NOT_CRAN=true, so the test fails in skip_on_cran() because it "looks like we are on cran"

test_that() does this nice thing where if it detects that there is no reporter active, it sets up an interactive reporter for you, and I think describe_it() (used by both describe() and it()) should do the same thing

testthat/R/test-that.R

Lines 41 to 44 in 4076b66

	reporter <- get_reporter()
	if (is.null(reporter)) {
	reporter <- local_interactive_reporter()
	}

That should mean you can run both the full describe() block and just an it() block interactively and both should get NOT_CRAN=true set up correctly.

---

Hadley also mentioned during discussion about this:

also I was wondering if skip_on_cran() should check interactive() first

the main downside of the current behaviour is that you sometimes want to nest skip_on_cran() inside a helper, and then you can’t run that interactively

Update: This part is solved by #1789

[hadley]

Note to self: look in git stash