skip_if_localized() #565

Activity

1. hadley commented on Oct 1, 2017

   

   hadley

   on Oct 1, 2017

   Member

   More actions

   Or we could add a language parameter to expect_error()? That's more likely to affect existing code, but it might be easy to discover.
2. hadley

   added

   expectation 🙀

   featurea feature request or enhancementa feature request or enhancement

   on Oct 2, 2017
3. hadley commented on Oct 2, 2017

   

   hadley

   on Oct 2, 2017

   Member

   More actions

   Hmmm, how do we know if you're localised?
4. gaborcsardi commented on Oct 2, 2017

   

   gaborcsardi

   on Oct 2, 2017

   Member

   More actions

   Maybe Sys.getenv("LANGUAGE") based on ?"environment variables"?
5. gaborcsardi commented on Oct 2, 2017

   

   gaborcsardi

   on Oct 2, 2017

   Member

   More actions

   This should be better I guess: https://github.com/wch/r-source/blob/0af92cb369681f3ef666451a6eeb895988c04113/tests/reg-tests-1d.R#L13-L29
6. hadley commented on Oct 3, 2017

   

   hadley

   on Oct 3, 2017

   Member

   More actions

   Something like

   is_english <- function() {
     lang <- Sys.getenv("LANGUAGE")
     if (identical(lang, "en")) {
       return(TRUE)
     }
     
     if(.Platform$OS.type == "windows") {
       lc <- sub("\\..*", "", sub("_.*", "", Sys.getlocale("LC_CTYPE")))
       lc == "English" || lc == "C"
     } else {
       lc <- sub("\\..*", "", Sys.getlocale("LC_MESSAGES"))
       lc == "C" || substr(lc, 1, 2) == "en"
     }
   }
7. hadley commented on Oct 4, 2017

   

   hadley

   on Oct 4, 2017

   Member

   More actions

   We need a different name because of localized vs localised. Maybe skip_if_not_en()?
8. hadley commented on Oct 4, 2017

   

   hadley

   on Oct 4, 2017

   Member

   More actions

   This feels awkward - I'd rather add a lang parameter to expect_error()
9. hadley

   closed this as completedin 506f1a1on Oct 4, 2017
10. hadley commented on Oct 9, 2017

    

    hadley

    on Oct 9, 2017

    Member

    More actions

    Unfortunately it looks like that gettext caches translations between calls making it difficult to switch languages back and forth in a single session. I'll go back to skip_if_translated()
11. hadley

    added a commit that references this issue on Oct 9, 2017

    Implement skip_if_translated

    ...

    This issue will close once commit 4b77f92 is merged into the 'main' branch.

    4b77f92
12. billdenney

    added a commit that references this issue on Feb 15, 2024

    Override error message translations

    ...

    This issue will close once commit 506f1a1 is merged into the 'master' branch.

    506f1a1