Bind in imports #1748
Bind in imports #1748
Conversation
Since the package environment is locked, we can only change bindings there, not add them. But that's ok because if we're trying to mock something that's not in the package, it must be imported from another namespace.
There was a problem hiding this comment.
Looks great!
This could be extracted in a function, and then we could loop over the imports of all dependencies of the current package. Then we have full mocking across the whole session. This will be useful for packages that depend on each other in an integrated stack.
R/mock2.R
Outdated
| @@ -48,6 +63,18 @@ with_mocked_bindings <- function(code, ..., .package = NULL) { | |||
|
|
|||
| # helpers ----------------------------------------------------------------- | |||
|
|
|||
| # Wrapper around local_bindings() that automatically unlocks and takes | |||
| # list of bindings. | |||
| local_env_bind <- function(env, bindings, frame = caller_env()) { | |||
R/mock2.R
Outdated
| bindings_found[in_pkg] <- TRUE | ||
|
|
||
| # Bindings in imports | ||
| for (env in env_parents(ns_env)) { |
There was a problem hiding this comment.
Nice use of env_parents(), I remember when you suggested it should stop at globalenv() years ago :)
|
What are you thinking would be extracted into a function? |
The imports updating with local cleanup, so you could apply it to the namespaces of all dependencies. Though I guess it has to be a bit more complicated because a same name could be bound to another function in other namespaces, so you'd need to check that it's the same function before mocking. |
|
If I understand what you're saying, I think you can already do that with (e.g.) local_mocked_bindings(sym = function(...) "x", .package = "rlang") |
|
oh right. Well that does look good enough and also maybe safer to do it explicitly. |
|
Yeah, for now, I wanted to make this explicit, because it somehow feels wrong to make it easy to change code owned by others. |
Allow new mocking functions to also mock functions that are imported from other packages.