New tool to compare global state before and after each test #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennybc
approved these changes
Jun 5, 2023
Co-authored-by: Jennifer (Jenny) Bryan <jenny.f.bryan@gmail.com>
|
Does this implementation leave the door open in case someone wants to check state only in certain tests, or configure how state is checked on a test-by-test basis? |
|
No, because I'm mostly imagining that people will only want to turn this on occasionally during debugging, just because it's a lot of work to run down all the false positives (as we've learned in renv). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1674
@lionel- could you please take a look at the implementation?
@jennybc could you please look at the docs?