Remove linebreaks from test descriptions in snapshots; fixes #1900 #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why the test-coverage GitHub Action it failing though.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fix issue #1900.
Newline ("\n") arguments in test descriptions are problematic for snapshots. They are converted to actual line breaks when writing the snapshot to a .md file here, causing a discrepancy between the test name in the snapshot (first line of the test, cut short at the newline argument) and the actual test name with newline arguments.
I think the easiest solution is to just remove the newline arguments in the test description within
SnapshotReporter.