Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove linebreaks from test descriptions in snapshots; fixes #1900 #1902

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

LDSamson
Copy link

This would fix issue #1900.

Newline ("\n") arguments in test descriptions are problematic for snapshots. They are converted to actual line breaks when writing the snapshot to a .md file here, causing a discrepancy between the test name in the snapshot (first line of the test, cut short at the newline argument) and the actual test name with newline arguments.

I think the easiest solution is to just remove the newline arguments in the test description within SnapshotReporter.

@LDSamson
Copy link
Author

I don't know why the test-coverage GitHub Action it failing though..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant