expect_setequal #557
Closed
expect_setequal #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Oct 2, 2017
| lab_act <- make_label(object, label) | ||
| lab_exp <- make_label(expected, expected.label) | ||
|
|
||
| steq <- compare_set(object, expected) |
There was a problem hiding this comment.
I think you could considerably simplify the implementation by just comparing sorted unique object and expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apropos of #528
This is an attempt to implement
expect_setequal. This version appears to work correctly, but I suspect there is still plenty of room for improvement so all feedback is appreciated.I tried to mimic the code for the other
expect_*functions, but I had to stray a little bit to make it work.Kind Regards,
Carl