Give advice on reusable selection helpers #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
reviewed
Aug 15, 2022
| To make this work you'll need to do two things: | ||
|
|
||
| * Wrap the whole thing in a function | ||
| * Use `any_of()` or `all_of()` instead of bare variable names |
There was a problem hiding this comment.
Does all_of() now return a vector of positions after the recent changes? If yes, do we have a unit test for the combination of all_of() and helpers like starts_with()? If not, we should keep #270 around, or open a new issue.
There was a problem hiding this comment.
Should we add an info bullet pointing to this page in the out-of-context error?
There was a problem hiding this comment.
I think nothing has changed with all_of(), except that (e.g) all_of(1) is now coerced to an integer vector.
And this is the Rd topic that peek_vars() points to 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #270
After writing this, I'm not sure this is quite the right place, but we definitely need this advice somewhere.