Deprecate .data #295
Merged
Deprecate .data #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #169
lionel-
approved these changes
Aug 16, 2022
| expect_identical(select_loc(c(foo = "foo"), .data$foo), c(foo = 1L)) | ||
| expect_identical(select_loc(c(foo = "foo"), .data[["foo"]]), c(foo = 1L)) | ||
| expect_identical(select_loc(letters2, .data$a:.data$b), c(a = 1L, b = 2L)) | ||
| expect_identical(select_loc(letters2, .data[["a"]]:.data[["b"]]), c(a = 1L, b = 2L)) | ||
| }) | ||
|
|
||
| test_that("use of .data is deprecated", { | ||
| x <- list(a = 1, b = 2, c = 3) |
There was a problem hiding this comment.
Should force verbosity so the test is reproducible within sessions.
There was a problem hiding this comment.
Lifecycle always warns in tests.
For latest error snapshots
Conflicts: tests/testthat/test-eval-walk.R
Conflicts: NEWS.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #169
This will fail until r-lib/lifecycle#129 is finished, but you should still be able to review it, and I thought it might be useful to see a concrete example.