Use the new "select" and "relocate" subscript actions
#300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
commented
Aug 17, 2022
| @@ -1,6 +1,4 @@ | |||
| with_subscript_errors <- function(expr, | |||
| type = "select", | |||
| call = caller_env()) { | |||
There was a problem hiding this comment.
You didn't use the call here so I've removed it
Comment on lines
36
to
41
| (expect_error(relocate_loc(x, a, before = c))) | ||
| Output | ||
| <error/vctrs_error_subscript_oob> | ||
| Error in `relocate_loc()`: | ||
| ! Can't subset columns that don't exist. | ||
| ! Can't select columns that don't exist. | ||
| x Column `c` doesn't exist. |
There was a problem hiding this comment.
I think this is good enough for OOB errors in before and after
| Error in `vec_as_location2_result()`: | ||
| Error: |
There was a problem hiding this comment.
Improvements from over on the vctrs side
DavisVaughan
force-pushed
the
feature/select-relocate-actions
branch
from
98600e9
to
7543d2b
Compare
lionel-
approved these changes
Aug 18, 2022
DavisVaughan
force-pushed
the
feature/select-relocate-actions
branch
from
dbff421
to
a4e4c51
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #271
Requires r-lib/vctrs#1619 (I'll merge that first and then update here)
Note that this means tidyselect now relies on dev vctrs.