Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation of system dependencies failing after running use_github_actions_tidy #1005

Closed
Robinlovelace opened this issue Feb 3, 2020 · 4 comments

Comments

@Robinlovelace
Copy link

Robinlovelace commented Feb 3, 2020

I read with great interest about GitHub actions in these (awesome comic themed!) slides: https://speakerdeck.com/jimhester/github-actions-for-r?slide=40

Following the instructions I tried:

use_github_actions_tidy()

For the package stplanr.

Good news: the outpute seems to have got the actions going.

Issue, the system requirements seem to fail on all platforms except for Windows: https://github.com/ropensci/stplanr/runs/420731417 (screenshot below)

I had a look at R-CMD-check.yml and guess that there is an underlying issue with the pkgdepends sysreqs package. Happy to open an issue there, but seeing as I first found this issue while using this package, and imagining that others may have similar issues, opening here as a starting point.

On a related note, wondering if there's a way to use RStudio's r-system-requirements project to support automated package dependencies for things like GDAL, on which stplanr depends, which is mentioned in the README here: https://github.com/rstudio/r-system-requirements

Thanks.

image

@Robinlovelace
Copy link
Author

Update, have just tried re-running the command after installing dev version and the resulting yaml files seem unchanged.

@jennybc
Copy link
Member

jennybc commented Feb 5, 2020

cc @jimhester

I'm going to close this because all usethis does is write files. I think this is an issue for https://github.com/r-lib/actions or https://github.com/r-hub/sysreqs.

FWIW I setup gh actions for googlesheets4 yesterday. I believe the sysreqs only works for Linux? For my macOS builds I had to add brew install this-and-that commands to install system requirements. For all but the simplest package, it is quite likely that the base workflow YAML is going to need customization.

@jennybc jennybc closed this as completed Feb 5, 2020
@Robinlovelace
Copy link
Author

Great, thanks for the pointers. Hope this issue, and your response, is useful to others.

@Robinlovelace
Copy link
Author

Heads-up @jennybc and @jimhester, good news: my colleague @layik fixed the issue with this commit: ropensci/stplanr@ad6b952

I'm unsure why the dependencies do not install as per r-hub/sysreqs#14 but happy that it's fixed and hope that others find this issue and the contents of the fix useful.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants