Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why doesn't use_lifecycle() import 1 function from lifecycle? #1419

Closed
jennybc opened this issue Apr 14, 2021 · 2 comments · Fixed by #1422
Closed

Why doesn't use_lifecycle() import 1 function from lifecycle? #1419

jennybc opened this issue Apr 14, 2021 · 2 comments · Fixed by #1422

Comments

@jennybc
Copy link
Member

jennybc commented Apr 14, 2021 •
edited

Looking at #1418, I wondered:

Why doesn't use_lifecycle() also do roxygen_ns_append("@importFrom lifecycle deprecated") (or, now that it exists, use_import_from("lifecycle", "deprecated"))?

I'm pretty sure it should.
@hadley
Copy link
Member

hadley commented Apr 16, 2021

What should happen if package-doc.R doesn't exist?

hadley added a commit that referenced this issue Apr 16, 2021
@hadley
Import lifecycle::deprecated() in use_lifecycle()
d2fcc3c 
Fixes #1419
@hadley hadley mentioned this issue Apr 16, 2021
Merged
@hadley
Copy link
Member

hadley commented Apr 16, 2021

It prompts you to create it; which seems fine to me.

hadley added a commit that referenced this issue Apr 16, 2021
@hadley
Import lifecycle::deprecated() in use_lifecycle() (#1422)
c555f4a 
Fixes #1419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Import lifecycle::deprecated() in use_lifecycle() r-lib/usethis
2 participants
@hadley @jennybc