Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "Verison: " in use_dev_version() #104

Merged
merged 3 commits into from Nov 2, 2017

Conversation

Projects
None yet
2 participants
@tjmahr
Copy link
Contributor

tjmahr commented Nov 2, 2017

No description provided.

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Nov 2, 2017

Can you please add a bullet to news too?

@tjmahr

This comment has been minimized.

Copy link
Contributor Author

tjmahr commented Nov 2, 2017

Done!

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Nov 2, 2017

Can you please credit yourself with (@yourname, #issuenumber).

@tjmahr

This comment has been minimized.

Copy link
Contributor Author

tjmahr commented Nov 2, 2017

Okay. I used this pull request number as the issue number because I didn't open an issue. (It was such a quick fix.)

@hadley hadley merged commit 3fed486 into r-lib:master Nov 2, 2017

2 of 3 checks passed

codecov/patch 0% of diff hit (target 16.22%)
Details
codecov/project 16.22% remains the same compared to 6bf74e5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Copy link
Member

hadley commented Nov 2, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.