New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't update suggested dependencies #1752
Conversation
test_that("use_tidy_versions() doesn't affect suggests", { | ||
skip_on_cran() | ||
withr::local_options(list(repos = c(CRAN = "https://cloud.r-project.org"))) | ||
|
||
create_local_package() | ||
use_package("cli", "Suggests") | ||
|
||
deps <- proj_deps() | ||
expect_equal(deps$version[deps$package == "cli"], "*") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a call to use_tidy_versions()
(or use_latest_dependencies()
) here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops 😆
Co-authored-by: Jennifer (Jenny) Bryan <jenny.f.bryan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My parting thought is: the tests mention use_tidy_versions()
but then actually call use_latest_dependencies()
. Do we want to make that less puzzling?
Oh I didn't even notice that; fixed now. |
Fixes #1749
Also a nice opportunity to use the new
proj_deps()
helper in the tests.