Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the correct urls from appveyor #240

Merged
merged 3 commits into from Feb 12, 2018

Conversation

Projects
None yet
2 participants
@llrs
Copy link
Contributor

llrs commented Feb 11, 2018

Previously the appveyor badge was not properly rendered as appveyor_info returned the url of the repository as the image. The change only affects the name of the urls returned by appveyor_info to be used by use_badge_appveyor.

Return the correct urls from appveyor
Previously the appveyor badge was not properly rendered as it returned the url of the repository as the image.
@jennybc

This comment has been minimized.

Copy link
Member

jennybc commented Feb 12, 2018

Thanks!

I tested this locally and found another pre-existing problem. Want to fix it too while you're making this PR? Please make the url assignment look like this:

  url <- file.path(
    "https://ci.appveyor.com",
    "project",
    gh$username,
    gh$repo
  )

The "project" part needs to be added.

Also go ahead and add a NEWS bullet about this fix.

llrs added some commits Feb 12, 2018

Add project to url
As per jennybc comment
@llrs

This comment has been minimized.

Copy link
Contributor Author

llrs commented Feb 12, 2018

I'm not sure if I should increment the package version, let me know which version scheme do you want, or if I should move the bullet under the 1.2.0.9000 version comments.

@jennybc

This comment has been minimized.

Copy link
Member

jennybc commented Feb 12, 2018

I'll merge and tweak the NEWS myself and tag you, so you see our style for future. I've made a note that we should clarify this in our contributing template. Which, ironically, this repo is not using itself! Will fix that too.

Thanks.

@jennybc jennybc merged commit f6fd935 into r-lib:master Feb 12, 2018

3 of 4 checks passed

codecov/patch 0% of diff hit (target 62.64%)
Details
codecov/project 62.6% (-0.05%) compared to 42c19e4
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@llrs

This comment has been minimized.

Copy link
Contributor Author

llrs commented Feb 13, 2018

Yes, I looked for it but I couldn't find any contributing template (or code of conduct for what it matters).
Glad to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.