Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function to help configure a GitHub PAT #257

Merged
merged 3 commits into from Feb 19, 2018

Conversation

Projects
None yet
2 participants
@jennybc
Copy link
Member

jennybc commented Feb 16, 2018

Fixes #248 browse_github_pat / use_github_pat

Still a WIP. Currently, pretty faithful to the PR made by @jeroen on devtools.

This should finish quickly, so @hadley, happy to get any opinions you have:

  • Name: [create|browse|use]_github_[pat|token]()? usethis functions that deal with the PAT accept it via the auth_token argument (Is that what we want? gh uses .token.)
  • Default scopes?
  • Default nickname (a.k.a. "description")?
  • Shall I immediately message about using edit_r_environ()? Even call it?

I know I need to rationalize PAT docs, check if interactive, use in-house UI functions, etc.

Screenshot:

screen shot 2018-02-15 at 11 53 50 pm

@jennybc jennybc force-pushed the use-github-pat branch from fec359b to cd905d7 Feb 16, 2018

@jennybc jennybc requested a review from hadley Feb 16, 2018

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Feb 16, 2018

I think browse_ would be the name most in keeping with the current behaviour.

Do we want to use the API to automate creation even further? Maybe it's worth pushing that off into gh, and considering later as part of an overhaul of how gh does auth?

@jennybc jennybc force-pushed the use-github-pat branch from cd905d7 to dbb9cab Feb 17, 2018

@jennybc

This comment has been minimized.

Copy link
Member Author

jennybc commented Feb 19, 2018

Do we want to use the API to automate creation even further? Maybe it's worth pushing that off into gh, and considering later as part of an overhaul of how gh does auth?

Yeah, I am not inclined to get into this with usethis for this release. I'd like to just make the web flow easier for an individual this time.

@jennybc jennybc force-pushed the use-github-pat branch from dbb9cab to 4f0be75 Feb 19, 2018

@jennybc jennybc changed the title WIP: function to help get a GitHub PAT Function to help configure a GitHub PAT Feb 19, 2018

@jennybc jennybc merged commit c905c12 into master Feb 19, 2018

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.