Add option usethis.protocol to change default globally #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGMT, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation that closes #492 feature request.
protocolto"https"or"ssh"There are no tests about protocol in https, only manual test with ssh protocol. I could add some for protocol https but I won't be running the manual tests so let me know what you wish on this.
About
match.arg, I wanted to userlang::arg_matchbut it is not use yet so I comply with the current standard for usethis. I can do another PR about migrating torlang::arg_match. Error message would be clearer and there would be no partial matching, which is interesting here forprotocolargument.