Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option usethis.protocol to change default globally #494

Merged
merged 3 commits into from Nov 13, 2018

Conversation

@cderv
Copy link
Contributor

@cderv cderv commented Nov 13, 2018

This is an implementation that closes #492 feature request.

  • Keep the "ssh" the default behaviour
  • Continue to match protocol to "https" or "ssh"

There are no tests about protocol in https, only manual test with ssh protocol. I could add some for protocol https but I won't be running the manual tests so let me know what you wish on this.

About match.arg, I wanted to use rlang::arg_match but it is not use yet so I comply with the current standard for usethis. I can do another PR about migrating to rlang::arg_match. Error message would be clearer and there would be no partial matching, which is interesting here for protocol argument.

@jennybc
Copy link
Member

@jennybc jennybc commented Nov 13, 2018

LGMT, thanks!

@jennybc jennybc merged commit 6fee375 into r-lib:master Nov 13, 2018
1 of 4 checks passed
@cderv cderv deleted the add-option-protocol branch Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants