Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more respectful of existing lines in write_union() #583

Merged
merged 7 commits into from Mar 16, 2019

Conversation

@khailper
Copy link
Contributor

@khailper khailper commented Jan 19, 2019

Closes #526 git_vaccinate() drops blank lines and repeated comments

Copy link
Member

@jennybc jennybc left a comment

Can you turn the problem as detailed by @jimhester in #526 into one or more new tests of write_union()?

@jimhester
Copy link
Member

@jimhester jimhester commented Feb 11, 2019

The code LGTM. @khailper can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).

@jennybc jennybc changed the title Closes #526 Be more respectful of existing lines in write_union() Mar 16, 2019
@jennybc jennybc merged commit bfc636c into r-lib:master Mar 16, 2019
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants